[XB] Xmas Garland 1.0.0 Patch Level 1

[Painbaker]

Painbaker submitted a new resource:

[XB] Xmas Garland - Xmas Garland

Xmas Garland

Read more about this resource...

 

[Mitchy71]

Thanks so much for this

 

[ichpen]

No worky for me... @Painbaker
Option enabled (default theme) in style props, nothing shows. Can't see a permission for it, what am I missing?

EDIT: pb_xmasgarland_PAGE_CONTAINER_css template mod doesn't show that it's applying?!?

The one looking for <xf:include template="google_analytics" />.

 

[Painbaker]

No worky for me... @Painbaker
Option enabled (default theme) in style props, nothing shows. Can't see a permission for it, what am I missing?

EDIT: pb_xmasgarland_PAGE_CONTAINER_css template mod doesn't show that it's applying?!?

The one looking for <xf:include template="google_analytics" />.

Are you using a custom style? XF version?

 

[🔥Iggy🔥]

i noticed 404s on the audio?.....but as im typing this and realizing i dont like the editor making sounds, its more of an observation than a complaint.

 

[🔥Iggy🔥]

it seems to miss the /community part of the url....fwiw...

 

[Andy.N]

Not working on the default style.

 

[Sebastiaan]

How to make this work with Themehouse styles?

 

[🔥Iggy🔥]

template mods work for me....using ui.x2

just seems like an issue with the js/audio

 

[🔥Iggy🔥]

i did verify the files are there(in /community tho) and proper permissions set....

 

[Painbaker]

Painbaker updated [XB] Xmas Garland with a new update entry:

1.0.0 Patch Level 1

Fix: the audio loading issue if the forum is not located in the root of the domain
Fix: change template modification hook to apply on custom styles and older XF versions

Read the rest of this update entry...

 

[Painbaker]

Not working on the default style.
View attachment 1256

Try the new update
I adjusted the template modification to apply on older XF versions and some custom styles

 

[Sebastiaan]

template mods work for me....using ui.x2

just seems like an issue with the js/audio

Please what template edits did you use...

 

[unproperlypropagated]

@Painbaker thanks for the addon. Is there a way to disable sound when typing?

 

[unproperlypropagated]

If anyone's interested to keep all functionality except the typing sounds:
EDIT: /js/xmas-garland/script.js
Remove:

        document.addEventListener('keydown', function (j)
        {
            let i = j.target;
            if (j.which in a)
            {
                let index = parseInt(a[j.which]);
                balls = new Balls(context, buffer.getSound(index));
                balls.play();
                let ball = document.querySelector('[data-note="' + index + '"]');
                toggleBounce(ball);
            }
        });

Minify and copy minified version to script.min.js on same dir.
Clear any cache if you use Cloudflare of this url:

https://domain.com/js/xmas-garland/script.min.js

 

[ichpen]

Are you using a custom style? XF version?

I figured it out. Your css hook/template mod was looking for google_analytics. Unfortunately this conflicts with Better analytics that renames the ga reference and precedes your template mod.

Also does not work with PixelExit styles where header is inside the navigation bar because there's nothing to hook into for your JS template mod.

It's cute but the sound is perpetually triggering which can/will irritate some members. Just a buyer beware note for this free addon

Thank you for this addon.