What's new
[XB] Xmas Garland

[XB] Xmas Garland 1.0.0 Patch Level 1

No permission to download
Overview Updates (1) History Discussion
No worky for me... @Painbaker
Option enabled (default theme) in style props, nothing shows. Can't see a permission for it, what am I missing?

EDIT: pb_xmasgarland_PAGE_CONTAINER_css template mod doesn't show that it's applying?!?

The one looking for <xf:include template="google_analytics" />.
 
Last edited:
ichpen said:
No worky for me... @Painbaker
Option enabled (default theme) in style props, nothing shows. Can't see a permission for it, what am I missing?

EDIT: pb_xmasgarland_PAGE_CONTAINER_css template mod doesn't show that it's applying?!?

The one looking for <xf:include template="google_analytics" />.
Click to expand...
Are you using a custom style? XF version?
 
i noticed 404s on the audio?.....but as im typing this and realizing i dont like the editor making sounds, its more of an observation than a complaint.
 
If anyone's interested to keep all functionality except the typing sounds:
EDIT: /js/xmas-garland/script.js
Remove:
JavaScript: 
        document.addEventListener('keydown', function (j)
        {
            let i = j.target;
            if (j.which in a)
            {
                let index = parseInt(a[j.which]);
                balls = new Balls(context, buffer.getSound(index));
                balls.play();
                let ball = document.querySelector('[data-note="' + index + '"]');
                toggleBounce(ball);
            }
        });

Minify and copy minified version to script.min.js on same dir.
Clear any cache if you use Cloudflare of this url:
Code: 
https://domain.com/js/xmas-garland/script.min.js
 
Painbaker said:
Are you using a custom style? XF version?
Click to expand...

I figured it out. Your css hook/template mod was looking for google_analytics. Unfortunately this conflicts with Better analytics that renames the ga reference and precedes your template mod.

Also does not work with PixelExit styles where header is inside the navigation bar because there's nothing to hook into for your JS template mod.

It's cute but the sound is perpetually triggering which can/will irritate some members. Just a buyer beware note for this free addon :)

Thank you for this addon.
 
Last edited:
unproperlypropagated said:
If anyone's interested to keep all functionality except the typing sounds:
EDIT: /js/xmas-garland/script.js
Remove:
JavaScript: 
        document.addEventListener('keydown', function (j)
        {
            let i = j.target;
            if (j.which in a)
            {
                let index = parseInt(a[j.which]);
                balls = new Balls(context, buffer.getSound(index));
                balls.play();
                let ball = document.querySelector('[data-note="' + index + '"]');
                toggleBounce(ball);
            }
        });

Minify and copy minified version to script.min.js on same dir.
Clear any cache if you use Cloudflare of this url:
Code: 
https://domain.com/js/xmas-garland/script.min.js
Click to expand...
Thank you - this is what I was looking for. The sounds when typing would not be popular on my site - I was looking for an option to turn them off, I didn't fully follow all that. Where do I find /js/xmas-garland/script.js - is that in templates?
 
Ok I've found it - added /js/xmas-garland/script.js to the forum address bar. Found the bit to remove. Didn't understand the rest of the instructions!

Would appreciate a bit of help with "Minify and copy minified version to script.min.js on same dir." @unproperlypropogated
 
unproperlypropagated said:
If anyone's interested to keep all functionality except the typing sounds:
EDIT: /js/xmas-garland/script.js
Remove:
JavaScript: 
        document.addEventListener('keydown', function (j)
        {
            let i = j.target;
            if (j.which in a)
            {
                let index = parseInt(a[j.which]);
                balls = new Balls(context, buffer.getSound(index));
                balls.play();
                let ball = document.querySelector('[data-note="' + index + '"]');
                toggleBounce(ball);
            }
        });

Minify and copy minified version to script.min.js on same dir.
Clear any cache if you use Cloudflare of this url:
Code: 
https://domain.com/js/xmas-garland/script.min.js
Click to expand...
Ok I've found it - added /js/xmas-garland/script.js to the forum address bar. Found the bit to remove. Didn't understand the rest of the instructions!

Would appreciate a bit of help with "Minify and copy minified version to script.min.js on same dir." if you could help please! Can't even work out how to remove/delete that section from the page!

Edit - have gone into the server under js and removed that section. How do I minify and copy to script.min.js?
 
Last edited:
You must log in or register to reply here.
Back
Top